feat(helm): sync TLS certificates from cloud secret manager via ESO (v0.2.1)#4
Merged
Merged
Conversation
…v0.2.1) When secrets.provider=external-secrets and tls.provider=secret, the chart now automatically creates ExternalSecret resources for each enabled component (VTOM, ITC, ITM, MFT) to sync TLS certificates from GCP SM / Azure KV / AWS SM. - values.yaml: set default names for tls.secret.*, add remoteKeys for TLS cert/key pairs, document the new provider combination - templates/common/secrets.yaml: add 4 ExternalSecret blocks (type: kubernetes.io/tls) gated on tls.enabled + tls.provider=secret, inside the existing external-secrets guard - values-client-template.yaml: document Options A/B/C for TLS, add commented TLS remoteKeys in all 3 cloud provider sections (Azure, AWS, GCP)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secrets.provider: external-secretsANDtls.provider: secret— no new flag neededExternalSecret(typekubernetes.io/tls) per enabled component (VTOM, ITC, ITM, MFT)cert-managerandtls.provider: nonebehavior is unchangedChanges
values.yaml: default names fortls.secret.*, newremoteKeysentries for TLS cert/key pairs, inline documentationtemplates/common/secrets.yaml: 4ExternalSecretblocks gated ontls.enabled + tls.provider=secretvalues-client-template.yaml: TLS Options A/B/C documented, commented TLSremoteKeysin all 3 cloud sectionsTest plan
helm lintpasses on all 4 cloud profiles (azure, gcp, aws, onpremise)helm templatewith--set secrets.provider=external-secrets --set tls.provider=secretgenerates 4ExternalSecretresources of typekubernetes.io/tlshelm templatewith defaulttls.provider: cert-managergenerates NO TLSExternalSecretkubectl get externalsecretshowsReady, resulting secret hastype: kubernetes.io/tls